Fix issue preventing non-root salt master running in VSCode integrated terminal #67085
Conversation
Akm0d
force-pushed
the
67083
branch
4 times, most recently
from
d0bb349 to
6ec7abb
Compare
Akm0d
changed the title
|
I was wondering if there is an estimate when this fix might be merged into 3007.x? |
|
I'm a little confused. The bug report that motivated this PR, #67083, has been closed. And yet the PR has not passed the requirements necessary for integration into 3007.x. It may be (probably is) that I don't understand PR workflow. Is this PR still moving forward? I should also mention that this problem also arises in 3006.x, so I would hope that any fixes appearing in 3007.2 will be back ported to 3006.9. Is that the case? |
|
@Akm0d rebae to 2006.x and add tests or close this if not interested in it anymore |
|
@Akm0d re-open this if you want to get it across the finish line. |
|
@dwoz I am spending all of my Salt development time on another bug #65265. I didn't submit a bug report issue for this problem, because I thought it was going to be fixed by this PR. Now that it is closed, should I submit a PR with the same changes? It doesn't appear @Akm0d is paying any attention to this. |
What does this PR do?
Fixes an issue preventing salt-master from running without root in VSCode integrated terminal.
What issues does this PR fix or reference?
Fixes #67083
Previous Behavior
Running salt-master without root in the VSCode integrated terminal results in an error during grains collection.
New Behavior
salt-master is able to run without root.
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes
Please review Salt's Contributing Guide for best practices, including the
PR Guidelines.
See GitHub's page on GPG signing for more information about signing commits with GPG.